Skip to content

(Minor & UI) Always show scroll bar for sidebar#3396

Merged
toshokanneko merged 2 commits intoOdyseeTeam:masterfrom
globbertot:sidebar-scroll-css
Jan 21, 2026
Merged

(Minor & UI) Always show scroll bar for sidebar#3396
toshokanneko merged 2 commits intoOdyseeTeam:masterfrom
globbertot:sidebar-scroll-css

Conversation

@globbertot
Copy link
Contributor

@globbertot globbertot commented Jan 14, 2026 •
edited by coderabbitai bot
Loading

Closes

This will close issue #2875

What is the current behavior?

The sidebar's scrollbar is only visible when hovering it, which can be confusing for some whether you can scroll or not.

What is the new behavior?

The sidebar's scrollbar will always be visible if there is overflowing.

Other information

Before: image

After: image

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe: UI improvement

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

Summary by CodeRabbit

  • Style
    • Navigation scrolling behavior simplified: overflow now consistently uses scroll instead of changing on hover or at specific desktop widths.
    • Desktop hover-triggered scrolling and width adjustments removed for more predictable interaction.
    • Compact/micro navigation state still preserves its special behavior so the condensed look remains unchanged.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The navigation component's overflow behavior is simplified by changing the main container's overflow from auto to scroll and removing responsive media query blocks that previously adjusted overflow visibility and width on hover.

Changes

Cohort / File(s) Summary
Navigation Styling Simplification
ui/scss/component/_navigation.scss		 Updated .navigation hover overflow from auto to scroll; removed the min-width media query block and hover-driven width/overflow adjustments in .navigation--push; added rule enforcing overflow-y: scroll except when .navigation--micro is present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰✨ The nav now scrolls so smooth and free,
No more toggle dance on hover spree,
Media queries trimmed away with care,
Simpler styles float through the air,
I hop with joy — a lighter fare!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: making the sidebar scrollbar always visible instead of only on hover, which directly aligns with the CSS modifications that shift from hover-based overflow-y behavior to always showing scroll.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

toshokanneko
toshokanneko reviewed Jan 20, 2026
View reviewed changes
Copy link
Contributor

@toshokanneko toshokanneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure about this. The scrollbar is hidden on purpose. Just like on YouTube and many other websites.

@globbertot
Copy link
Contributor Author

globbertot commented Jan 20, 2026

Well, yeah i half-agree, personally i've not found it that distracting.

What about only always showing it when the sidebar is maximized? Let me know if that sounds okay.

@toshokanneko
Copy link
Contributor

toshokanneko commented Jan 20, 2026

Showing it when it's open definitely sounds better because you can't really get into that state by accident. Thanks btw. 😉

@toshokanneko toshokanneko merged commit 886cc43 into OdyseeTeam:master Jan 21, 2026
3 checks passed
@globbertot globbertot deleted the sidebar-scroll-css branch January 21, 2026 09:04
@globbertot globbertot mentioned this pull request Jan 21, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toshokanneko toshokanneko toshokanneko left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@globbertot @toshokanneko